Skip to content

Handle new interface format keywords from NeuroConv 0.6.0 #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 2, 2025
Merged

Handle new interface format keywords from NeuroConv 0.6.0 #997

merged 6 commits into from
Jul 2, 2025

Conversation

@rly
Copy link
Collaborator

@rly rly commented Jul 1, 2025 •
edited
Loading

Working on #957.

Address #957 (comment)

  • Generates JSON Schema for interfaces using NeuroConv 0.6.0 which updates format: file -> format: file-path and format: directory -> format: directory-path among other changes.
  • Updates GUIDE code to detect file-path and directory-path instead of file and directory for displaying a file selector vs directory selector
  • Updates internal GUIDE code to use format: file-path and format: directory-path. I think I caught all the instances.

Alternatively, I could have converted the JSON Schema on read to change file-path back to file and not change the rest of GUIDE, but 1) I think file-path is more informative, and 2) that conversion feels less clean.

Other changes in the interfaces will be addressed in a separate PR to keep this one clean.

@rly rly changed the title Update format: file and directory to file-path and directory-path Handle new interface format keywords from NeuroConv 0.6.0 Jul 1, 2025
@rly rly requested a review from pauladkisson July 1, 2025 07:23
@rly rly marked this pull request as ready for review July 1, 2025 07:23
@rly rly enabled auto-merge July 1, 2025 07:27
pauladkisson
pauladkisson approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rly
Copy link
Collaborator Author

rly commented Jul 2, 2025

The new JSON schema / NeuroConv 0.6.0 also means:

  1. Intan Recording Interface has a new ignore_integrity_checks option (default: false)
  2. Spike2 Recording Interface no longer accepts .smr file
  3. Tiff Imaging Interface accepts a new enum photon_series_type (OnePhotonSeries or TwoPhotonSeries, default: TwoPhotonSeries)
  4. Sbx Imaging Interface accepts a new enum photon_series_type (OnePhotonSeries or TwoPhotonSeries, default: TwoPhotonSeries)
  5. Video Interface accepts a new metadata key name (default: Videos)
  6. Neuralynx Recording Interface now accepts ".ncs" files

@rly rly merged commit 637d624 into main Jul 2, 2025
27 checks passed
@rly rly deleted the rename_file_directory_types branch July 2, 2025 03:36
@rly rly mentioned this pull request Jul 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pauladkisson pauladkisson pauladkisson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rly @pauladkisson